lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Nov 2007 16:46:21 -0500 From: "J. Bruce Fields" <bfields@...ldses.org> To: Dave Hansen <haveblue@...ibm.com> Cc: Trond Myklebust <trond.myklebust@....uio.no>, ezk@...sunysb.edu, akpm@...l.org, linux-kernel@...r.kernel.org, hch@...radead.org Subject: Re: [PATCH 2/2] fix up new filp allocators On Fri, Nov 09, 2007 at 01:35:22PM -0800, Dave Hansen wrote: > On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote: > > > #include <linux/sunrpc/svc.h> > > > #include <linux/nfsd/nfsd.h> > > > #include <linux/nfsd/cache.h> > > > +#include <linux/file.h> > > > #include <linux/mount.h> > > > #include <linux/workqueue.h> > > > #include <linux/smp_lock.h> > > > @@ -1303,7 +1304,7 @@ static inline void > > > nfs4_file_downgrade(struct file *filp, unsigned int share_access) > > > { > > > if (share_access & NFS4_SHARE_ACCESS_WRITE) { > > > - put_write_access(filp->f_path.dentry->d_inode); > > > + drop_file_write_access(filp); > > > filp->f_mode = (filp->f_mode | FMODE_READ) & ~FMODE_WRITE; > > > } > > > } > > > > Hmm... The NFS server may also try to 'upgrade' an open file request to > > a read/write request whenever the client issues a new OPEN request for > > WRITE using the same open_owner. > > Can you point me to some code? I'll try and go fix it up. See fs/nfsd/nfs4state.c:nfs4_upgrade_open(). I suspect that there are other reasons why what nfsd is doing here is a bad idea, and that we should really be getting a new file descriptor. But I haven't figured out yet what to do instead. --b. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists