linux-kernel - Re: [PATCH] make ds1wm driver to check ds1wm_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Nov 2007 20:08:32 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	eric miao <eric.y.miao@...il.com>, linux-kernel@...r.kernel.org,
	szabolcs.gyurko@....hu
Subject: Re: [PATCH] make ds1wm driver to check ds1wm_platform_data pointer against NULL

On Fri, Nov 09, 2007 at 05:02:38PM -0800, Andrew Morton (akpm@...ux-foundation.org) wrote:
> > @@ -351,6 +351,10 @@ static int ds1wm_probe(struct platform_device *pdev)
> >  		goto err0;
> >  	}
> >  	plat = pdev->dev.platform_data;
> > +	if (!plat) {
> > +		ret = -ENXIO;
> > +		goto err0;
> > +	}
> >  	ds1wm_data->bus_shift = plat->bus_shift;
> >  	ds1wm_data->pdev = pdev;
> >  	ds1wm_data->pdata = plat;
> 
> I don't understand this change.  Could you please provide some more details
> regarding what problem it is solving?  How can pdev->dev.platform_data==NULL
> come about?

If I understood correctly, it is posible to call platform's probe
callback without previously calling platform_device_add_data() to setup
platform_data.

But actually I failed to find any user of this platform driver in
vanilla kernel, so it is hard to say if driver is used properly or not
by external modules, and thus this change is very likely valid.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/