linux-kernel - Re: [PATCH 6/6] MN10300: Add MTD flash support for the ASB2303 board [try #5]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1194667538.2588.49.camel@shinybook.infradead.org>
Date:	Fri, 09 Nov 2007 23:05:38 -0500
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-am33-list@...hat.com
Subject: Re: [PATCH 6/6] MN10300: Add MTD flash support for the ASB2303
	board [try #5]

Dunno why it's called "try #5" when I haven't directly received it even
once yet.

On Fri, 2007-11-09 at 15:35 +0000, David Howells wrote:
> Add MTD flash support for the ASB2303 board.

We're trying to avoid taking new simple map drivers -- you should be
able to use a platform device instead.

> --- a/drivers/mtd/chips/jedec_probe.c
> +++ b/drivers/mtd/chips/jedec_probe.c
> @@ -1883,11 +1883,13 @@ static inline __u8 finfo_uaddr(const struct amd_flash_info *finfo, int device_ty
>  
>  	uaddr = finfo->uaddr[uaddr_idx];
>  
> +#ifndef CONFIG_MN10300_UNIT_ASB2303
>  	if (uaddr != MTD_UADDR_NOT_SUPPORTED ) {
>  		/* ASSERT("The unlock addresses for non-8-bit mode
>  		   are bollocks. We don't really need an array."); */
>  		uaddr = finfo->uaddr[0];
>  	}
> +#endif

I think this is a NOP for the chip in question anyway, isn't it?

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/