[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 11 Nov 2007 11:30:16 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: Erez Zadok <ezk@...sunysb.edu>, linux-kernel@...r.kernel.org,
Ulrich Drepper <drepper@...hat.com>,
Roland McGrath <roland@...hat.com>,
"Andrew G. Morgan" <morgan@...nel.org>,
Casey Schaufler <casey@...aufler-ca.com>,
Chris Wright <chrisw@...s-sol.org>,
James Morris <jmorris@...ei.org>,
Serge Hallyn <serue@...ibm.com>,
Stephen Smalley <sds@...ho.nsa.gov>
Subject: Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar <mingo@...e.hu> wrote:
>
> * Erez Zadok <ezk@...sunysb.edu> wrote:
>
> > Small patch below fixes compile error.
>
> > + char name[sizeof(current->comm)];
> > warned++;
> > printk(KERN_INFO
> > "warning: process `%s' sets w/ old libcap\n",
> > - get_task_comm(current));
> > + get_task_comm(name, current));
>
> that's buggy - get_task_comm() returns void.
>
> the proper fix would be to first do a get_task_comm() then pass in
> 'name' as an argument to printk.
yup, it is all dependent upon http://lkml.org/lkml/2007/11/8/231
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists