lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 11 Nov 2007 09:23:41 +0000
From:	James Courtier-Dutton <James@...erbug.co.uk>
To:	Xavier Bestel <xavier.bestel@...e.fr>,
	Benny Halevy <bhalevy@...asas.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: Coding Style: indenting with tabs vs. spaces

DervishD wrote:
>     Bonjour Xavier :)
>
>  * Xavier Bestel <xavier.bestel@...e.fr> dixit:
>   
>> Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit :
>>     
>>>  * Benny Halevy <bhalevy@...asas.com> dixit:
>>>       
>>>> I would like to hear peoples opinion about the indentation convention
>>>> described below that I personally found the most practical with
>>>> several different editors.
>>>>         
>>> While I respect you opinion about tabs, I find tab indentation the most
>>> evil thing ever invented. Even if done right (that is, not indenting
>>> using a mixture of spaces and tabs), the only advantage is that you save
>>> a few bytes.
>>>       
>> Who cares ?
>>     
>
> About the space saving? Not me, of course. It's just that I didn't see
> any other advantage.
>
>   
>> The only advantage is that people can make tabs as big (or as small)
>> as they wish. Tabs become "logical indentation". So one's indentation
>> isn't forced on anotherone's editor.
>>     
>
> The only way of having a sane indentation using tabs is to make sure
> that ALL indentation are tabs, not a mix of tabs and spaces (spaces, if
> any, should be at the end of indentation for aesthetical purposes, but
> should be removed without the logical indentation being lost). A good
> editor can ensure that all indentation are tabs and not a mix, but a
> good editor can adapt indentation to your likings when loading the file
> and save the file translating your favourite indentation back to spaces
> or whatever.
>
> If everybody used tabs correctly, indenting using tabs would be great,
> but IMHO indenting with spaces is much better.
>
>     Raúl Núñez de Arenas Coronado
>
>   

Just use the linux

./scripts/checkpatch.pl --file

It does all the indent checks for you before you submit a patch.
I.e. I checks that one has not mixed tabs with spaces etc.
So, any patches to the Linux kernel will have tabs used correctly.
Where is the problem?

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ