linux-kernel - [PATCH 2/2] [IA32-EMU] Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20071112181758.GF7296@cvg>
Date:	Mon, 12 Nov 2007 21:17:58 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] [IA32-EMU] Remove dead code


>From d1e9989b50aac63f95c6c152fdc655a95aa3ab69 Mon Sep 17 00:00:00 2001
From: Cyrill V. Gorcunov <gorcunov@...il.com>
Date: Mon, 12 Nov 2007 21:02:34 +0300
Subject: [PATCH 2/2] [IA32-EMU] Remove dead code

This patch does remove useless second time checking of fsave argument
in save_i387_ia32() routine. It's possible the compiler is doing
the same but that is much better to remove the dead code explicitly.

Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
---
 arch/x86/ia32/fpu32.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/ia32/fpu32.c b/arch/x86/ia32/fpu32.c
index 7ab8969..d49174a 100644
--- a/arch/x86/ia32/fpu32.c
+++ b/arch/x86/ia32/fpu32.c
@@ -174,8 +174,6 @@ int save_i387_ia32(struct task_struct *tsk,
 	if (fsave)
 		return 0;
 	err |= __put_user(tsk->thread.i387.fxsave.swd, &buf->status);
-	if (fsave)
-		return err ? -1 : 1;
 	err |= __put_user(X86_FXSR_MAGIC, &buf->magic);
 	err |= __copy_to_user(&buf->_fxsr_env[0], &tsk->thread.i387.fxsave,
 			      sizeof(struct i387_fxsave_struct));

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/