[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071112115353.227f35cb.akpm@linux-foundation.org>
Date: Mon, 12 Nov 2007 11:53:53 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: David Howells <dhowells@...hat.com>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
linux-am33-list@...hat.com
Subject: Re: [PATCH 1/6] Suppress A.OUT library support if
!CONFIG_BINFMT_AOUT [try #5]
On Mon, 12 Nov 2007 15:34:40 +0000 David Howells <dhowells@...hat.com> wrote:
> Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > > +# -*- makefile -*-
> >
> > what's that?
>
> Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its
> an Assembly file and not a makefile. This causes it to attempt to do
> automatic indentation on it. Do you want me to drop these annotation
> comments?
Doesn't worry me, but I'd suggest that such annotation be added to all such
files in a single separate patch.
otoh it'd be pretty dumb of emacs if there wasn't some way of telling it
the type of a file external from that file itself.
> > Note that because of unexport-asm-pageh.patch I turned the above hunk into
> >
> > ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
> > unifdef-y += a.out.h
> > endif
> >
> > which seems logical to me. We'll see how it tests out.
>
> Are you talking about in linux/Kbuild or in asm-generic/Kbuild.asm or both?
I forget which Kbuild file that was. But with the above change, both
include/asm-generic/Kbuild.asm and include/linux/Kbuild are using
unifdef-y.
> Anyway, it sounds reasonable.
>
> David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists