linux-kernel - Re: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071112090136.GF301@shadowen.org>
Date:	Mon, 12 Nov 2007 09:01:54 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Erez Zadok <ezk@...sunysb.edu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote:
> Andrew,
> 
> I'm getting minor warnings when applying two patches from
> <http://userweb.kernel.org/~akpm/mmotm/>
> 
> It's probably not serious but I wonder if checkpatch catches this.
> 
> Applying patch..git-net.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.
> 
> Applying patch..mnt_unbindable-fix.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.

We do have checks for UTF-8.  The commit message problems are usually real
names in Signed-off-by:s being "complex" and being in their email locale
not UTF-8.  It is a problem area for sure as people want their email to
look right in their email to the list, and yet they need it in UTF-8 for git.

Yeah it looks like we pick it up ok, the message could do with a little
love:

    apw@...ky$ ~/git/checkpatch/checkpatch.pl -q --no-tree ./git-net.patch
    ERROR: Invalid UTF-8
    #229:
	This is based on a patch by Vicenç Beltran Querol.

    ERROR: Invalid UTF-8
    #398:
	by Toralf Förster:

    ERROR: Invalid UTF-8
    #773:
	Signed-off-by: Lutz Preßler <Lutz.Pressler@...Net.DE>

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/