linux-kernel - Re: checkpatch.pl and no newline handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Nov 2007 10:18:58 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch.pl and no newline handling

On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote:
> the current checkpatch.pl does not reject new files that lack a
> newline, yet rejects patches that fix newlines in files ... quite the
> opposite of what we actually want

Nice.  Just what the world needs.  I wonder what the heck that format
means.  Obviously the "corrupt" check is wrong as a "\ No newline" line
is valid not corrupt.  Now when is "\ No newline" a good thing and when
a bad thing.  It _looks_ like it is 'bound' to the line before, and if
so then its pretty simple.

Bad:
> +moo
> \ No newline at end of file

Good:
> -moo
> \ No newline at end of file

/me goes read the source for diff.  Sigh.

Thanks for the report.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/