linux-kernel - Re: mm snapshot broken-out-2007-11-13-04-14 Build Fails due kobject cleanup (Resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071113152229.GB32528@linux.vnet.ibm.com>
Date:	Tue, 13 Nov 2007 20:52:29 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	akpm@...ux-foundation.org
Cc:	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregkh@...e.de, apw@...dowen.org
Subject: Re: mm snapshot broken-out-2007-11-13-04-14 Build Fails due kobject cleanup (Resend)

Hi Andrew,

The build fails, with the build error

drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pci/hotplug/rpadlpar_sysfs.c:59: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store: 
drivers/pci/hotplug/rpadlpar_sysfs.c:79: error: expected ˜; before ˜return
drivers/pci/hotplug/rpadlpar_sysfs.c: At top level:
drivers/pci/hotplug/rpadlpar_sysfs.c:89: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c:92: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:80: warning: control reaches end of non-void function
make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

This is caused by the patch
gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch.

Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
--
--- linux-2.6.24-rc2/drivers/pci/hotplug/rpadlpar_sysfs.c	2007-11-13 19:42:26.000000000 +0530
+++ linux-2.6.24-rc2/drivers/pci/hotplug/~rpadlpar_sysfs.c	2007-11-13 20:29:09.000000000 +0530
@@ -54,7 +54,7 @@ static ssize_t add_slot_show(struct kobj
 	return sprintf(buf, "0\n");
 }
 
-static ssize_t remove_slot_store(struct kobjet *kobj,
+static ssize_t remove_slot_store(struct kobject *kobj,
 				 struct kobj_attribute *attr,
 				 const char *buf, size_t nbytes)
 {
@@ -74,7 +74,7 @@ static ssize_t remove_slot_store(struct 
 
 	rc = dlpar_remove_slot(drc_name);
 	if (rc)
-		return rc
+		return rc;
 
 	return nbytes;
 }

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/