linux-kernel - Re: [PATCH 1/3]: tty - fix network driver interactions with TCGET/SET calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071113153933.2e56057d@the-village.bc.nu>
Date:	Tue, 13 Nov 2007 15:39:33 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3]: tty - fix network driver interactions with
 TCGET/SET calls

> net/irda/irnet/irnet_ppp.c: In function 'dev_irnet_ioctl':
> net/irda/irnet/irnet_ppp.c:738: warning: passing argument 2 of 'kernel_termios_to_user_termios_1' from incompatible pointer type
> net/irda/irnet/irnet_ppp.c:750: warning: passing argument 1 of 'user_termios_to_kernel_termios_1' from incompatible pointer type


net/irda isn't tty layer and is completely and totally hosed, has been
for ages. It fakes some tty bits to fool pppd and does it wrong.

The warnings are good - they are showing up real standing bugs.
Unfortunately as its not a real tty device they are not at all easy to
fix.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/