linux-kernel - Re: [PATCH 24/24] make vsmp a paravirt client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4739DD2F.5060605@goop.org>
Date:	Tue, 13 Nov 2007 09:21:51 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
CC:	Andi Kleen <ak@...e.de>, lguest@...abs.org, kiran@...lemp.com,
	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, chrisw@...s-sol.org,
	tglx@...utronix.de, anthony@...emonkey.ws,
	akpm@...ux-foundation.org, mingo@...e.hu
Subject: Re: [PATCH 24/24] make vsmp a paravirt client

Glauber de Oliveira Costa wrote:
> the ifdef only exists because, as I said, the code itself will be always
> compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it
> from here, putting it there issue. Kiran seem to prefer this way, but I
> don't really have a preference.

It would be better to have the ifdef in setup_64.c and just make the
compilation of vsmp_64.c depend on CONFIG_X86_VSMP.  If the ifdef really
rankles you could use a weak stub function somewhere, or define an
inline stub in vsmp.h.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/