linux-kernel - Re: [PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071112174721.c304264d.akpm@linux-foundation.org>
Date:	Mon, 12 Nov 2007 17:47:21 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andi Kleen <ak@...e.de>
Cc:	Erez Zadok <ezk@...sunysb.edu>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] arch/x86/kernel/setup_64.c compile error
 (MMOTM-2007-11-10-19-05)

On Tue, 13 Nov 2007 02:32:29 +0100 Andi Kleen <ak@...e.de> wrote:

> 
> > hm, that doesn't seem right.  We want to run the early quirks on non-ACPI
> > kernel too, surely?
> 
> Most of early-quirks.c makes only sense with ACPI. The only exception would
> be the ATI timer override check, but frankly it's fairly unlikely that there 
> are any ATI based boards around who still have mptables. Non ACPI 
> tables would very likely just run in PIC mode and then need no timer overrides
> anyways.
> 
> Originally on i386 the early quirks equivalent was 100% ACPI specific.
> 

OK....  But what's The Right Thing To Do here?  Would one be reasonable in
expecting that one can add a new early quirk which is independent from acpi
and have it still work on non-acpi builds?

Seems better to decouple the two things if poss?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/