linux-kernel - Re: 2.6.24-rc2-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473A8B97.5050909@acm.org>
Date:	Tue, 13 Nov 2007 22:45:59 -0700
From:	Zan Lynx <zlynx@....org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Gabriel C <nix.or.die@...glemail.com>,
	linux-kernel@...r.kernel.org, Ulrich Drepper <drepper@...hat.com>,
	Roland McGrath <roland@...hat.com>
Subject: Re: 2.6.24-rc2-mm1

Andrew Morton wrote:
[cut]
> hm, that was supposed to shut itself off after 100 messages:
> 
> 	if (unlikely(clone_flags & (CLONE_DETACHED|CLONE_STOPPED))) {
> 		static int __read_mostly count = 100;
> 
> 		if (count && printk_ratelimit()) {
> 			char comm[TASK_COMM_LEN];
> 
> 			count--;
> 			printk(KERN_INFO "fork(): process `%s' used deprecated "
> 					"clone flags 0x%lx\n",
> 				get_task_comm(comm, current),
> 				clone_flags & (CLONE_DETACHED|CLONE_STOPPED));
> 		}
> 	}
> 
> I don't see how you got 151 instances.  I guess I'm having another stupid
> day.

It looks like a simple race, two threads do count-- before doing 
if(count), resulting in an almost infinite loop.  Probably.

atomic_test_and_dec might work.







-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/