[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0711140707120.25487@ask.diku.dk>
Date: Wed, 14 Nov 2007 07:09:40 +0100 (CET)
From: Julia Lawall <julia@...u.dk>
To: "Robert P. J. Day" <rpjday@...shcourse.ca>
Cc: khali@...ux-fr.org, i2c@...sensors.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
>> From: Julia Lawall <julia@...u.dk>
>>
>> Drop #include <linux/moduleparam.h> in files that also include #include
>> <linux/module.h>. module.h includes moduleparam.h already.
>
> i'm not convinced that's a good idea. while module.h does currently
> (and unfortunately) include moduleparam.h, there may come a day when
> those header files are refactored to actually make sense, at which
> point all those missing moduleparam.h inclusions will cause all sorts
> of bad things to happen.
They were removed from the drivers/media files in August:
9c12224a607a4b22ab86784e3394b52810b9507c
Perhaps they should be put back there then?
julia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists