linux-kernel - [PATCH 2/4] drivers/net: Drop unnecessary continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711140914000.26019@ask.diku.dk>
Date:	Wed, 14 Nov 2007 09:14:35 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [PATCH 2/4] drivers/net: Drop unnecessary continue

From: Julia Lawall <julia@...u.dk>

Continue is not needed at the bottom of a loop.

The semantic patch implementing this change is as follows:

@@
statement S;
@@

for (...;...;...) {
   ...
   if (...)
- {
     S
-   continue;
- }
}

Signed-off-by: Julia Lawall <julia@...u.dk>
---

diff -u -p -b -B a/drivers/net/ni65.c b/drivers/net/ni65.c
--- a/drivers/net/ni65.c 2007-10-22 11:25:14.000000000 +0200
+++ b/drivers/net/ni65.c 2007-11-13 22:49:02.000000000 +0100
@@ -427,10 +427,8 @@ static int __init ni65_probe1(struct net
  		}
  		if(cards[i].vendor_id) {
  			for(j=0;j<3;j++)
-				if(inb(ioaddr+cards[i].addr_offset+j) != cards[i].vendor_id[j]) {
+				if(inb(ioaddr+cards[i].addr_offset+j) != cards[i].vendor_id[j])
  					release_region(ioaddr, cards[i].total_size);
-					continue;
-			  }
  		}
  		break;
  	}
diff -u -p -b -B a/drivers/net/s2io.c b/drivers/net/s2io.c
--- a/drivers/net/s2io.c 2007-10-22 11:25:15.000000000 +0200
+++ b/drivers/net/s2io.c 2007-11-13 22:49:53.000000000 +0100
@@ -3599,10 +3599,8 @@ static void restore_xmsi_data(struct s2i
  		writeq(nic->msix_info[i].data, &bar0->xmsi_data);
  		val64 = (s2BIT(7) | s2BIT(15) | vBIT(i, 26, 6));
  		writeq(val64, &bar0->xmsi_access);
-		if (wait_for_msix_trans(nic, i)) {
+		if (wait_for_msix_trans(nic, i))
  			DBG_PRINT(ERR_DBG, "failed in %s\n", __FUNCTION__);
-			continue;
-		}
  	}
  }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/