linux-kernel - Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Nov 2007 11:54:50 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Joe Perches <joe@...ches.com>
cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] - [12/15] - remove defconfig ptr comparisons to 0 -
 include/asm-x86

Joe,

can you please CC the relevant maintainers on patches ?

On Tue, 13 Nov 2007, Joe Perches wrote:

> Remove defconfig ptr comparison to 0
>
> The memcpy from memory location 0 sure looks odd.

The memcpy from 0 is completely bogus.

I bet this should have been a memset(&header, 0, ....), which is not
necessary at all, when the return value of acpi_get_table_header()
would be evaluated.

/me wonders why this never exploded

    tglx

> Remove sparse warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> ---
> 
> diff --git a/include/asm-x86/mach-es7000/mach_mpparse.h b/include/asm-x86/mach-es7000/mach_mpparse.h
> index 8aa1054..a1dd66f 100644
> --- a/include/asm-x86/mach-es7000/mach_mpparse.h
> +++ b/include/asm-x86/mach-es7000/mach_mpparse.h
> @@ -29,7 +29,7 @@ extern int mps_oem_check(struct mp_config_table *mpc, char *oem,
>  static inline int es7000_check_dsdt(void)
>  {
>  	struct acpi_table_header header;
> -	memcpy(&header, 0, sizeof(struct acpi_table_header));
> +	memcpy(&header, (void *)0, sizeof(struct acpi_table_header));
>  	acpi_get_table_header(ACPI_SIG_DSDT, 0, &header);
>  	if (!strncmp(header.oem_id, "UNISYS", 6))
>  		return 1;
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/