linux-kernel - Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071114123931.GF5064@kernel.dk>
Date:	Wed, 14 Nov 2007 13:39:31 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

On Wed, Nov 14 2007, Rusty Russell wrote:
> Hi Jens,
> 
>     As you asked for some time ago.  Of course, it turns out that the eject
> command ignores the error anyway, but it's nice that it now errors.
> 
>     Not entirely comfortable with this patch: there's a req->errors but
> that seems to have some existing semantics I'm not sure of, so I simply
> added a new way of flagging an error.

It is a bit of a hack, but it's not really your fault. ->errors is
somewhat messy and has different meaning depending on the request type.
I'll add your patch and then do a sanitize on top of it, so that we can
switch things over to a unified ->errno instead.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/