linux-kernel - Re: [2.6 patch] scsi/lpfc/: possible cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <473AFB5D.5030303@emulex.com>
Date:	Wed, 14 Nov 2007 08:42:53 -0500
From:	James Smart <James.Smart@...lex.Com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	James.Bottomley@...elEye.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] scsi/lpfc/: possible cleanups

ACK

-- james s

Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the following needlessly global functions static:
>   - lpfc_els.c: lpfc_register_new_vport()
>   - lpfc_els.c: lpfc_issue_els_fdisc()
>   - lpfc_els.c: lpfc_issue_fabric_iocb()
>   - lpfc_els.c: lpfc_fabric_abort_vport()
>   - lpfc_hbadisc.c: lpfc_dev_loss_tmo_handler()
>   - lpfc_hbadisc.c: lpfc_mbx_cmpl_clear_la()
>   - lpfc_hbadisc.c: lpfc_disc_flush_list()
>   - lpfc_hbadisc.c: __lpfc_find_node()
>   - lpfc_init.c: lpfc_hb_timeout()
>   - lpfc_init.c: lpfc_block_mgmt_io()
>   - lpfc_sli.c: __lpfc_sli_release_iocbq()
>   - lpfc_sli.c: lpfc_sli_next_hbq_slot()
>   - lpfc_sli.c: lpfc_sli_hbqbuf_init_hbqs()
>   - lpfc_sli.c: lpfc_sli_hbqbuf_find()
>   - lpfc_sli.c: __lpfc_sli_issue_iocb()
> - #if 0 the following unused global functions:
>   - lpfc_els.c: lpfc_fabric_abort_flogi()
>   - lpfc_hbadisc.c: lpfc_find_node()
>   - lpfc_hbadisc.c: lpfc_findnode_rpi()
> - remove the unused exports
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> 
>  drivers/scsi/lpfc/lpfc_crtn.h    |   19 -------------------
>  drivers/scsi/lpfc/lpfc_els.c     |   18 ++++++++++++++----
>  drivers/scsi/lpfc/lpfc_hbadisc.c |   13 +++++++++----
>  drivers/scsi/lpfc/lpfc_init.c    |   22 +++++++++++-----------
>  drivers/scsi/lpfc/lpfc_sli.c     |   10 +++++-----
>  drivers/scsi/lpfc/lpfc_vport.c   |    3 ---
>  6 files changed, 39 insertions(+), 46 deletions(-)
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/