linux-kernel - Re: [PATCH 4/4] sound/pci: Drop unnecessary continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hy7d1du3c.wl%tiwai@suse.de>
Date:	Wed, 14 Nov 2007 11:01:11 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	perex@...e.cz, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/4] sound/pci: Drop unnecessary continue

At Wed, 14 Nov 2007 09:15:51 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Continue is not needed at the bottom of a loop.
> 
> The semantic patch implementing this change is as follows:
> 
> @@
> @@
> 
> for (...;...;...) {
>    ...
>    if (...) {
>      ...
> -   continue;
>    }
> }
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Applied to ALSA tree.  Thanks.


Takashi

> ---
> 
> diff -u -p -b -B a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
> --- a/sound/pci/intel8x0.c 2007-10-22 11:25:53.000000000 +0200
> +++ b/sound/pci/intel8x0.c 2007-11-13 23:53:44.000000000 +0100
> @@ -2144,7 +2144,6 @@ static int __devinit snd_intel8x0_mixer(
>   				snd_printk(KERN_ERR "Unable to initialize codec #%d\n", i);
>   			if (i == 0)
>   				goto __err;
> -			continue;
>   		}
>   	}
>   	/* tune up the primary codec */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/