linux-kernel - Re: [PATCH] libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071114175028.GA9546@devserv.devel.redhat.com>
Date:	Wed, 14 Nov 2007 12:50:28 -0500
From:	Alan Cox <alan@...hat.com>
To:	Mark Lord <liml@....ca>
Cc:	Tejun Heo <htejun@...il.com>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Sebastian Kemper <sebastian_ml@....net>,
	Jeff Garzik <jgarzik@...ox.com>, Alan Cox <alan@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libata-scsi:  be tolerant of 12-byte ATAPI commands in 16-byte CDBs

On Wed, Nov 14, 2007 at 12:44:23PM -0500, Mark Lord wrote:
> Sebastian Kemper reported that issuing CD/DVD commands under libata
> is not fully compatible with ide-scsi.  In particular, the 
> GPCMD_SET_STREAMING
> was being rejected at the host level in some instances.
> 
> The reason is that libata-scsi insists upon the cmd_len field exactly 
> matching
> the SCSI opcode being issued, whereas ide-scsi tolerates 12-byte commands
> contained within a 16-byte (cmd_len) CDB.
> 
> There doesn't seem to be a good reason for us to not be compatible there,
> so here is a patch to fix libata-scsi to permit SCSI opcodes so long as
> they fit within whatever size CDB is provided.
> 
> Signed-off-by: Mark Lord <mlord@...ox.com>

Acked-by: Alan Cox <alan@...hat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/