linux-kernel - Re: [Git Patch][Resend] Makefile: fix wrong dirs when making cscope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071114191836.GA10047@uranus.ravnborg.org>
Date:	Wed, 14 Nov 2007 20:18:36 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-kbuild@...r.kernel.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [Git Patch][Resend] Makefile: fix wrong dirs when making cscope

Hi WANG.

I ended up adding the following patch.
It fixes both x86_64 and i386 and is simpler.
Plus I included the ncscope.out thing in the same patch.

	Sam

commit 5683c81430f9cf2a2eaf71ce93291f00b528b6c4
Author: WANG Cong <xiyou.wangcong@...il.com>
Date:   Thu Nov 8 17:22:11 2007 +0800

    kbuild: fix cscope so it does not emit warnings
    
    This patch fixed the following errors when doing "make cscope" and
    "make cscope ARCH=um".
    
      FILELST cscope.files
    find: arch/i386: No such file or directory
      MAKE    cscope.out
    
      FILELST cscope.files
    find: include/asm-i386: No such file or directory
      MAKE    cscope.out
    
    In addition it teach kbuild to delete ncscope.out at mrproper
    
    Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
    Signed-off-by: Sam Ravnborg <sam@...nborg.org>

diff --git a/Makefile b/Makefile
index cb740d4..1d48b0f 100644
--- a/Makefile
+++ b/Makefile
@@ -1086,7 +1086,7 @@ MRPROPER_DIRS  += include/config include2 usr/include
 MRPROPER_FILES += .config .config.old include/asm .version .old_version \
                   include/linux/autoconf.h include/linux/version.h      \
                   include/linux/utsrelease.h                            \
-		  Module.symvers tags TAGS cscope*
+		  Module.symvers tags TAGS *cscope*
 
 # clean - Delete most, but leave enough to build external modules
 #
@@ -1318,7 +1318,7 @@ endif
 
 ifeq ($(ALLSOURCE_ARCHS),)
 ifeq ($(ARCH),um)
-ALLINCLUDE_ARCHS := $(ARCH) $(SUBARCH)
+ALLINCLUDE_ARCHS := $(SRCARCH) $(SUBARCH)
 else
 ALLINCLUDE_ARCHS := $(SRCARCH)
 endif
@@ -1327,12 +1327,7 @@ else
 ALLINCLUDE_ARCHS := $(ALLSOURCE_ARCHS)
 endif
 
-# Take care of arch/x86
-ifeq ($(ARCH), $(SRCARCH))
-ALLSOURCE_ARCHS := $(ARCH)
-else
-ALLSOURCE_ARCHS := $(ARCH) $(SRCARCH)
-endif
+ALLSOURCE_ARCHS := $(SRCARCH)
 
 define find-sources
         ( for arch in $(ALLSOURCE_ARCHS) ; do \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/