linux-kernel - Re: [stable] [PATCH] dmaengine: Fix broken device refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071114214543.GC9901@kroah.com>
Date:	Wed, 14 Nov 2007 13:45:43 -0800
From:	Greg KH <greg@...ah.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Shannon Nelson <shannon.nelson@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	hskinnemoen@...el.com, stable@...nel.org
Subject: Re: [stable] [PATCH] dmaengine: Fix broken device refcounting

On Wed, Nov 07, 2007 at 11:46:07AM -0700, Dan Williams wrote:
> From: Haavard Skinnemoen <hskinnemoen@...el.com>
> 
> When a DMA device is unregistered, its reference count is decremented
> twice for each channel: Once dma_class_dev_release() and once in
> dma_chan_cleanup(). This may result in the DMA device driver's
> remove() function completing before all channels have been cleaned
> up, causing lots of use-after-free fun.
> 
> Fix it by incrementing the device's reference count twice for each
> channel during registration.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>
> [dan.j.williams@...el.com: kill unnecessary client refcounting]
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@...el.com>
> Cc: stable@...nel.org

I don't see this in Linus's tree yet, right?

When it goes in, can you resend it to the stable@...nel.org people?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/