linux-kernel - Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2007 12:35:21 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

On Thu, Nov 15 2007, Rusty Russell wrote:
> On Thursday 15 November 2007 19:47:05 Jens Axboe wrote:
> > On Thu, Nov 15 2007, Rusty Russell wrote:
> > > If blk_rq_map_sg returns more than was allocated, it's a bug, and
> > > something's already been overwritten.  BUG_ON() is probably the right
> > > thing here.
> >
> > It really just means that it mapped more segments than the block layer
> > said it would. Usually that wont overwrite memory here since scsi rounds
> > up on allocating the sg list, but it indeed can. Similar code has been
> > in scsi_lib.c for ages, I'd suggest covering that in the same patch.
> 
> Good point.  I assume that you've not seen these printks in recent memory?

I have not, they usually show up if we have bugs in the merge accounting
logic in the block layer (the merge functions and blk_rq_map_sg() not
agreeing). It's been ages since that was an issue, so I'm fine with the
bug.

> This covers both cases:
> 
> Subject: [PATCH] scsi: BUG_ON() impossible condition.

You can add my

Acked-by: Jens Axboe <jens.axboe@...cle.com>

when you pass it through James, it should go in that way.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/