linux-kernel - Re: EIP is at device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2007 14:15:36 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Yasunori Goto <y-goto@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...ru>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: EIP is at device_shutdown+0x32/0x60

On Thu, 15 Nov 2007 21:55:34 +0900,
Yasunori Goto <y-goto@...fujitsu.com> wrote:

> /**
>  * device_shutdown - call ->shutdown() on each device to shutdown.
>  */
> void device_shutdown(void)
> {
>         struct device * dev, *devn;
> 
>         list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
>                                 kobj.entry) {
>                 if (dev->bus && dev->bus->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->bus->shutdown(dev);
>                 } else if (dev->driver && dev->driver->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->driver->shutdown(dev);
>                 }
>         }
> }
> --------
> When oops occured, dev->driver pointed kset_ktype's address,
> and dev->driver->shutdown was the address of bus_type_list.
> So, Oops was caused by "Illegal operation fault".
> kset_ktypes is pointed by system_kset.
> 
> If my understanding is correct, this loop can't distinguish between
> struct device and struct kset, but both are connected in this list,
> right? It may be the cause of this.

Uh. This fits with my observations on s390 as well (the list is not
corrupted, but it contains entities that are not devices...)

The other entries under /sys/devices (on my system css0, platform,
qeth) are all struct devices. This sysdev stuff is headache-inducing :(
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/