linux-kernel - Re: [PATCH] Fix build failure when CONFIG_INFINIBAND_IPOIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071115144946.GJ5128@skynet.ie>
Date:	Thu, 15 Nov 2007 14:49:47 +0000
From:	mel@...net.ie (Mel Gorman)
To:	Tony Breeds <tony@...eyournoodle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Roland Dreier <rolandd@...co.com>,
	Linux Kernel ML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix build failure when CONFIG_INFINIBAND_IPOIB_CM is not defined.

On (14/11/07 14:40), Tony Breeds didst pronounce:
> Fixes:
>   CC [M]  drivers/infiniband/ulp/ipoib/ipoib_main.o
> drivers/infiniband/ulp/ipoib/ipoib_main.c: In function ???ipoib_init_module???:
> drivers/infiniband/ulp/ipoib/ipoib_main.c:1269: error: invalid lvalue in assignment
> 
> In the case where CONFIG_INFINIBAND_IPOIB_CM is not defined ipoib_max_conn_qp is #defined to 0.
> 
> Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
> 
> ---
> 
>  drivers/infiniband/ulp/ipoib/ipoib_main.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 623458e..aeb5a01 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1265,8 +1265,9 @@ static int __init ipoib_init_module(void)
>  	ipoib_sendq_size = roundup_pow_of_two(ipoib_sendq_size);
>  	ipoib_sendq_size = min(ipoib_sendq_size, IPOIB_MAX_QUEUE_SIZE);
>  	ipoib_sendq_size = max(ipoib_sendq_size, IPOIB_MIN_QUEUE_SIZE);
> -
> +#ifdef CONFIG_INFINIBAND_IPOIB_CM
>  	ipoib_max_conn_qp = min(ipoib_max_conn_qp, IPOIB_CM_MAX_CONN_QP);
> +#endif

The patch fixes the compile although having a variable name #defined as 0
seems a bit of an unexpected suprise.

Either way, when applied with the hotfixes, bl6-13 on
http://test.kernel.org successfully boots.

>  
>  	ret = ipoib_register_debugfs();
>  	if (ret)
> 
> Yours Tony
> 
>   linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
>   Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/