linux-kernel - Re: [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071115153748.GD4973@linux-mips.org>
Date:	Thu, 15 Nov 2007 15:37:48 +0000
From:	Ralf Baechle DL5RB <ralf@...ux-mips.org>
To:	Gautham R Shenoy <ego@...ibm.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Rusty Russel <rusty@...tcorp.com.au>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Oleg Nesterov <oleg@...sign.ru>,
	Paul E McKenney <paulmck@...ibm.com>,
	Richard Gooch <rgooch@...f.csiro.au>,
	Tigran Aivazian <tigran@...azian.fs.co.uk>,
	Shoahua Li <shaohua.li@...ux.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Nathan Lynch <ntl@...ox.com>, Paul Jackson <pj@....com>,
	Christoph Lameter <clameter@....com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Akinobu Mita <akinobu.mita@...il.com>
Subject: Re: [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with
	get_online_cpus()

On Thu, Nov 15, 2007 at 07:22:02PM +0530, Gautham R Shenoy wrote:

> Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use
> get_online_cpus and put_online_cpus instead as it highlights
> the refcount semantics in these operations.
> 
> The new API guarantees protection against the cpu-hotplug operation,
> but it doesn't guarantee serialized access to any of the local data
> structures. Hence the changes needs to be reviewed.
> 
> In case of pseries_add_processor/pseries_remove_processor, use
> cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the
> cpu_present_map there.
> 
> Signed-off-by: Gautham R Shenoy <ego@...ibm.com>
> ---
>  Documentation/cpu-hotplug.txt                |   11 ++++++-----
>  arch/mips/kernel/mips-mt-fpaff.c             |   10 +++++-----

Acked-by: Ralf Baechle <ralf@...ux-mips.org>

for the MIPS part.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/