[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071115161249.GE6216@localhost.sw.ru>
Date: Thu, 15 Nov 2007 19:12:49 +0300
From: Alexey Dobriyan <adobriyan@...ru>
To: akpm@...l.org
Cc: linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: [PATCH] proc: use BUG_ON() in de_put()
It's much more visible that some printk. I still has an unexplained oops
in proc, so let's leave it for a while.
Signed-off-by: Alexey Dobriyan <adobriyan@...ru>
---
fs/proc/inode.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -37,12 +37,7 @@ void de_put(struct proc_dir_entry *de)
{
if (de) {
lock_kernel();
- if (!atomic_read(&de->count)) {
- printk("de_put: entry %s already free!\n", de->name);
- unlock_kernel();
- return;
- }
-
+ BUG_ON(atomic_read(&de->count) == 0);
if (atomic_dec_and_test(&de->count)) {
if (de->deleted) {
printk("de_put: deferred delete of %s\n",
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists