linux-kernel - Re: [patch 08/16] skge: fix ram buffer size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.9999.0711150849100.2786@woody.linux-foundation.org>
Date:	Thu, 15 Nov 2007 08:50:41 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [patch 08/16] skge: fix ram buffer size calculation



On Thu, 15 Nov 2007, Stephen Hemminger wrote:
>
> I can't reproduce the users problem with the hardware I have. And 
> without the patch the dual port board doesn't work. So it is a question 
> of regression, versus fixing pre-existing bugs.

Yeah. Five years ago I might have said that it's important to fix 
pre-existing bugs, but all the ACPI and suspend etc problems have long 
since convinced me that regressions are *much* more important than stuff 
that never worked.

> I am okay with reverting the patch, as a temporary state, but concerned 
> with how to make progress in fixing this.

Well, the original bug-report did contain a suggested workaround too.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/