linux-kernel - Re: EIP is at device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071115181834.GE24531@suse.de>
Date:	Thu, 15 Nov 2007 10:18:34 -0800
From:	Greg KH <gregkh@...e.de>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Yasunori Goto <y-goto@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...ru>, linux-kernel@...r.kernel.org
Subject: Re: EIP is at device_shutdown+0x32/0x60

On Thu, Nov 15, 2007 at 06:50:06PM +0100, Kay Sievers wrote:
> On Nov 15, 2007 5:34 PM, Greg KH <gregkh@...e.de> wrote:
> > On Thu, Nov 15, 2007 at 09:55:34PM +0900, Yasunori Goto wrote:
> > > > On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan <adobriyan@...ru> wrote:
> > > >
> > > > > Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1
> > > > > (1) and during 2.6.24 cycle (2):
> > > > >
> > > > >   kernel_restart
> > > > >   sys_reboot
> > > > >   [garbage]
> > > > > Code: 8b 88 a8 00 00 00 85 c9 74 04 89
> > > > > EIP is at device_shutdown+0x32/0x60
> > > >
> > > > Yes, all my test boxes did that - it's what I referred to in the releaee
> > > > notes.  Greg is pondering the problem - seem he's the only person who
> > > > cannot reproduce it ;)
> > >
> > > Fortunately, my ia64 box reproduces this oops "every time".
> > > So, I could chase it.
> > >
> > > device_shutdown() function in drivers/base/power/shutdown.c
> > > is followings.
> > > -----------
> > > /**
> > >  * device_shutdown - call ->shutdown() on each device to shutdown.
> > >  */
> > > void device_shutdown(void)
> > > {
> > >         struct device * dev, *devn;
> > >
> > >         list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
> > >                                 kobj.entry) {
> > >                 if (dev->bus && dev->bus->shutdown) {
> > >                         dev_dbg(dev, "shutdown\n");
> > >                         dev->bus->shutdown(dev);
> > >                 } else if (dev->driver && dev->driver->shutdown) {
> > >                         dev_dbg(dev, "shutdown\n");
> > >                         dev->driver->shutdown(dev);
> > >                 }
> > >         }
> > > }
> > > --------
> > > When oops occured, dev->driver pointed kset_ktype's address,
> > > and dev->driver->shutdown was the address of bus_type_list.
> > > So, Oops was caused by "Illegal operation fault".
> > > kset_ktypes is pointed by system_kset.
> > >
> > > If my understanding is correct, this loop can't distinguish between
> > > struct device and struct kset, but both are connected in this list,
> > > right? It may be the cause of this.
> >
> > Hm, no, it should just be a list of devices for the kset, but I'll go
> > verify that this is correct.
> 
> Care to try this:
>   +       system_kset = kset_create_and_register("system", NULL,
>   +                                              &devices_kset->kobj, NULL);
> 
> We should not join the kset, only use it as a parent.

ARGH!

<snip loads of curse words...>

that should do it, let me go test.

Actually, once that is changed, the whole kset_create_and_register can
drop that last argument, we never want to create a kset as part of
another one...

The kset's kobject should not belong to any kset at all, I really messed
that one up.

Yet another reason why this patchset really matters, this crap isn't
even understood well by the people trying to maintain it...

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/