linux-kernel - Re: User Mode Linux still broken in 2.6.23.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200711151457.22395.rob@landley.net>
Date:	Thu, 15 Nov 2007 14:57:21 -0600
From:	Rob Landley <rob@...dley.net>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
	akpm@...ux-foundation.org, Chris Wright <chrisw@...s-sol.org>
Subject: Re: User Mode Linux still broken in 2.6.23.1

On Thursday 15 November 2007 00:02:55 Greg KH wrote:
> On Wed, Nov 14, 2007 at 11:58:15PM -0600, Rob Landley wrote:
> > On Wednesday 14 November 2007 12:54:44 Greg KH wrote:
> > > On Sat, Nov 03, 2007 at 11:51:50PM -0500, Rob Landley wrote:
> > > > Building with the attached .config on x86-64, it does this:
> > > >
> > > >   CC      arch/um/kernel/smp.o
> > > > In file included from include/asm/arch/tlb.h:11,
> > > >                  from include/asm/tlb.h:4,
> > > >                  from arch/um/kernel/smp.c:8:
> > > > include/asm-generic/tlb.h: In function ???tlb_flush_mmu???:
> > > > include/asm-generic/tlb.h:76: error: implicit declaration of function
> > > > ???release_pages??? include/asm-generic/tlb.h: In function
> > > > ???tlb_remove_page???:
> > > > include/asm-generic/tlb.h:105: error: implicit declaration of
> > > > function ???page_cache_release??? make[1]: *** [arch/um/kernel/smp.o]
> > > > Error 1 make: *** [arch/um/kernel] Error 2
> > > >
> > > > I've been doing the following to fix it.  I know it's not the right
> > > > fix, (see the earlier thread about it at
> > > > http://lkml.org/lkml/2007/8/24/441 ) but could the one line fix go
> > > > into the -stable queue 2.6.23 while a proper fix goes into 2.6.24?
> > >
> > > I think the patches that I have just added to the stable queue for
> > > 2.6.23.2 will fix this.  If not, please let me know after testing.
> >
> > Where do I find these patches to test?  I know where to find the stable
> > releases, but not the "stable queue".
> >
> > Documentation/stable_kernel_rules.txt just says there _is_ a stable
> > queue, not where to access it.  Google's first hit for "linux stable
> > queue" was
> > http://git.kernel.org/?p=linux/kernel/git/chrisw/stable-queue.git;a=short
> >log which apparently stopped updating in march...
> >
> > Happy to test the patch you mentioned, if I can figure out where to find
> > it...
>
> It's at:
> 	http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summar
>y
>
> Chris and I used to have separate queues, but that got messy, I suppose
> we should just delete those old copies...

In a freshly extracted 2.6.23 tarball, I applied the 4 uml-*.patch files from 
stable-queue/review-2.6.23-2 in sequence (all applied cleanly), and then did 
the following:

cat > mini.conf << EOF &&
CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_LBD=y
CONFIG_BLK_DEV=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_EXT2_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf 

Then I did:

make -j 2 ARCH=um

And it still breaks:

  CC      arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
                 from include/asm/tlb.h:4,
                 from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of 
function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of 
function ‘page_cache_release’
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

My .config is attached.

> thanks,
>
> greg k-h

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

View attachment ".config" of type "text/plain" (5598 bytes)