linux-kernel - Re: x86 32-bit machine check handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071115053639.GA7552@one.firstfloor.org>
Date:	Thu, 15 Nov 2007 06:36:39 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Max Asbock <masbock@...ibm.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	lkml <linux-kernel@...r.kernel.org>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com
Subject: Re: x86 32-bit machine check handler

> I found patch from about three years ago that implemented a 32-bit
> version of the x86_64 machine check handler. Do you know of any newer
> attempts?

No.

> However, given the merge of x86, a single implementation should be able
> to handle both the 32-bit and 64-bit cases. I tried to build the 64-bit
> machine check handler (mce_64.c) for 32-bit to see what kind problems it
> would run into. So far I found a few things:
> - there is no idle_notifier_register in 32-bit x86

There used to be one, just needs to be readded.

> - there is no oops_begin in 32-bit x86
> - register names are different (rip, cs)

regs->rip -> instruction_pointer() 
->cs just needs a similar macro

> So it looks like giving 32-bit x86 the same machine check support as in
> 64-bit is both feasible and desirable.

Yep.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/