linux-kernel - [PATCH]: PNP: Increase the value of PNP constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1195198798.2460.18.camel@yakui_zhao.sh.intel.com>
Date:	Fri, 16 Nov 2007 15:39:58 +0800
From:	Zhao Yakui <yakui.zhao@...el.com>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org, shaohua.li@...el.com
Subject: [PATCH]: PNP: Increase the value of PNP constant

Subject: PNP: Increase the value of PNP constant
From: Zhao Yakui  <yakui.zhao@...el.com>

On some systems the number of resources(IO,MEM) returnedy by PNP
device is greater than the PNP constant, for example motherboard devices. 
It brings that some resources can't be reserved and resource confilicts.
This will cause PCI resources are assigned wrongly in some systems, and
cause hang. This is a regression since we deleted ACPI motherboard
driver and use PNP system driver.

Andrew, I thought this is an urgent issue and should be fixed ASAP, and
this is a good candidate for -stable tree

Signed-off-by: Li Shaohua <shaohua.li@...el.com>
Signed-off-by: Zhao Yakui <yakui.zhao@...el.com>

---
 drivers/pnp/pnpacpi/rsparser.c |   18 ++++++++++++++++--
 include/linux/pnp.h            |    4 ++--
 2 files changed, 18 insertions(+), 4 deletions(-)

Index: linux-2.6.24-rc2/include/linux/pnp.h
===================================================================
--- linux-2.6.24-rc2.orig/include/linux/pnp.h
+++ linux-2.6.24-rc2/include/linux/pnp.h
@@ -13,8 +13,8 @@
 #include <linux/errno.h>
 #include <linux/mod_devicetable.h>
 
-#define PNP_MAX_PORT		8
-#define PNP_MAX_MEM		4
+#define PNP_MAX_PORT		24
+#define PNP_MAX_MEM		12
 #define PNP_MAX_IRQ		2
 #define PNP_MAX_DMA		2
 #define PNP_NAME_LEN		50
Index: linux-2.6.24-rc2/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- linux-2.6.24-rc2.orig/drivers/pnp/pnpacpi/rsparser.c
+++ linux-2.6.24-rc2/drivers/pnp/pnpacpi/rsparser.c
@@ -82,9 +82,11 @@ static void pnpacpi_parse_allocated_irqr
 	while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
 	       i < PNP_MAX_IRQ)
 		i++;
-	if (i >= PNP_MAX_IRQ)
+	if (i >= PNP_MAX_IRQ) {
+		printk(KERN_ERR "Exceed the max number of IRQ resource: "
+				"%d \n",PNP_MAX_IRQ);
 		return;
-
+	}
 #ifdef CONFIG_X86
 	if (gsi < 16 && (triggering != ACPI_EDGE_SENSITIVE ||
 				polarity != ACPI_ACTIVE_HIGH)) {
@@ -173,6 +175,10 @@ static void pnpacpi_parse_allocated_dmar
 		}
 		res->dma_resource[i].start = dma;
 		res->dma_resource[i].end = dma;
+	} else {
+		printk(KERN_ERR "Exceed the max number of DMA resource: "
+				"%d \n",PNP_MAX_DMA);
+		return;
 	}
 }
 
@@ -194,6 +200,10 @@ static void pnpacpi_parse_allocated_iore
 		}
 		res->port_resource[i].start = io;
 		res->port_resource[i].end = io + len - 1;
+	} else {
+		printk(KERN_ERR "Exceed the max number of IO Resource: "
+				"%d \n",PNP_MAX_PORT);
+		return;
 	}
 }
 
@@ -217,6 +227,10 @@ static void pnpacpi_parse_allocated_memr
 
 		res->mem_resource[i].start = mem;
 		res->mem_resource[i].end = mem + len - 1;
+	} else {
+		printk(KERN_ERR "Exceed the max number of Mem Resource: "
+				"%d \n",PNP_MAX_MEM);
+		return;
 	}
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/