linux-kernel - Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Nov 2007 22:22:54 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Jonas Stare <jonas.stare@...plescout.se>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

On Friday 16 November 2007, Jonas Stare wrote:
> Resubmit of IDE-probing-patch. It now checks hwif->drives[unit].present instead of
> forced_geom and there is also an if-statement so it doesn't change back to the master
> unless it have to. I choose to put it inside the if-statement that checks the return
> code from ide_wait_not_busy, since it shouldn't revert back to the master drive unless
> something is wrong and we have to leave the function. (I also left the old SELECT_DRIVE
> after the for-loop so that we will select the master if everything is ok.) Inside the
> if-statement or not makes not big difference until you get more than two drives on the
> ide-bus...but this code should be ready for it. :)
> 
> Signed-off-by: Jonas Stare <jonas.stare@...plescout.se>

Patch looks fine (thanks for fixing it) but please replace the changelog
above with the proper patch description (more like in your first mail which
contained the description of the problem encountered and of the solution,
also please try to keep it within 80-columns limit) - for git history patch
changelog is not really that interesting/valuable.

PS patch summary ("Subject:") may also be improved while at it - it should
describe the main goal of the patch, also since patch will be applied to
the current git tree giving the kernel version is not necessary.

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/