linux-kernel - Re: [PATCH] 21285: Report baud rate back via termios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071119154137.GA30129@flint.arm.linux.org.uk>
Date:	Mon, 19 Nov 2007 15:41:37 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 21285: Report baud rate back via termios

On Mon, Nov 19, 2007 at 03:12:22PM +0000, Alan Cox wrote:
> Currently reports back the requested rate not the result of the divides
> but thats an easy fix for someone with h/w
> 
> Signed-off-by: Alan Cox <alan@...hat.com>

Ack for first hunk.  When can this be merged?  I assume it has to wait
for tty_encode_baud_rate() to appear in mainline?

> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c linux-2.6.24-rc2-mm1/drivers/serial/21285.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c	2007-11-16 17:20:48.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/serial/21285.c	2007-11-16 18:35:29.000000000 +0000
> @@ -277,6 +279,8 @@
>  	if (termios->c_iflag & INPCK)
>  		port->read_status_mask |= RXSTAT_FRAME | RXSTAT_PARITY;
>  
> +	tty_encode_baud_rate(tty,  baud, baud);
> +
>  	/*
>  	 * Which character status flags should we ignore?
>  	 */
> @@ -301,6 +305,7 @@
>  	*CSR_UARTCON = 1;
>  
>  	spin_unlock_irqrestore(&port->lock, flags);
> +	
>  }
>  
>  static const char *serial21285_type(struct uart_port *port)

This hunk isn't required.

Note also that no one reads linux-arm@...r.kernel.org.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/