| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071119045733.GA3829@darkstar.te-china.tietoenator.com> Date: Mon, 19 Nov 2007 12:57:33 +0800 From: Dave Young <hidave.darkstar@...il.com> To: Marcel Holtmann <marcel@...tmann.org> Cc: linux-kernel@...r.kernel.org, bluez-devel@...ts.sf.net Subject: Re: [PATCH][another try]bluetooth rfcomm tty_close before destruct Hi, This is the right patch which will not touch original tty logic. Please ignore last one submited by me. Regards dave Subject: rfcomm_dev_del could be called twice time in release function. one by rfcomm_tty_hangup, another by rfcomm_release_dev, this will cause the device being destructed before rfcomm_tty_close. Signed-off-by: Dave Young <hidave.darkstar@...il.com> --- tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -upr linux/net/bluetooth/rfcomm/tty.c linux.new/net/bluetooth/rfcomm/tty.c --- linux/net/bluetooth/rfcomm/tty.c 2007-11-19 10:48:32.000000000 +0800 +++ linux.new/net/bluetooth/rfcomm/tty.c 2007-11-19 12:48:10.000000000 +0800 @@ -424,8 +424,8 @@ static int rfcomm_release_dev(void __use /* Shut down TTY synchronously before freeing rfcomm_dev */ if (dev->tty) tty_vhangup(dev->tty); - - rfcomm_dev_del(dev); + else if (!test_bit(RFCOMM_RELEASE_ONHUP, &dev->flags)) + rfcomm_dev_del(dev); rfcomm_dev_put(dev); return 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists