linux-kernel - Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071119225210.GA23798@suse.de>
Date:	Mon, 19 Nov 2007 14:52:10 -0800
From:	Greg KH <gregkh@...e.de>
To:	David Miller <davem@...emloft.net>
Cc:	david-b@...bell.net, stern@...land.harvard.edu,
	zwane@....linux.org.uk, tytso@....edu,
	torvalds@...ux-foundation.org, stable@...nel.org,
	reviews@...cw.f00f.org, rdunlap@...otime.net, mkrufky@...uxtv.org,
	linux-usb-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, jmforbes@...uxtx.org,
	dely.l.sy@...el.com, davej@...hat.com, chuckw@...ntumlinux.com,
	cebbert@...hat.com, cavokz@...il.com, alan@...rguk.ukuu.org.uk,
	akpm@...ux-foundation.org
Subject: Re: [patch 19/26] USB: mutual exclusion for EHCI init and port
	resets

On Mon, Nov 19, 2007 at 02:32:41PM -0800, David Miller wrote:
> From: David Brownell <david-b@...bell.net>
> Date: Mon, 19 Nov 2007 11:59:55 -0800
> 
> > > This addition certainly won't hurt.  Did we ever get any feedback as to 
> > > whether it actually helped?
> > 
> > ISTR that davem refused to try it, after reporting an
> > intermittent failure on the original patch (which only
> > addresses one end of that hardware race).
> > 
> > So, no ... but given we know that closing only one side
> > of the race isn't quite enough, I think we need it anyway.
> 
> I think we should put all these changes in because at a minimum
> it's a step in the right direction even if it doesn't close
> the hole %100.
> 
> So please let's merge the mutex and the msleep() change in
> ASAP, thanks.

The msleep one is queued up for the next Linus pull, and after it goes
in, I'll add it to the -stable trees as well.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/