linux-kernel - Re: SCSI breakage on non-cache coherent architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071119.003802.100741794.davem@davemloft.net>
Date:	Mon, 19 Nov 2007 00:38:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	benh@...nel.crashing.org
Cc:	James.Bottomley@...senPartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	rmk@....linux.org.uk
Subject: Re: SCSI breakage on non-cache coherent architectures

From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Date: Mon, 19 Nov 2007 16:35:23 +1100

> I'm not sure what is the best way to fix that. Internally, I've done
> some test whacking some ____cacheline_aligned in the scsi_cmnd data
> structure to verify I no longer get random SLAB corruption when using my
> USB but that significantly bloats the size of the structure on archs
> such as ppc64 that don't need it and have a large cache line size.
> 
> Unfortunately, I don't think there's any existing Kconfig symbol or arch
> provided #define to tell us that we are on a non-coherent arch afaik
> that could be used to make that conditional.
> 
> Another option would be to kmalloc the buffer (wasn't it the case before
> btw ?) but I suppose some people will scream at the idea due to how the
> command pools are done...

You could make a ____dma_cacheline_aligned and use that.
It seems pretty reasonable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/