linux-kernel - Re: [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071119133849.bcfe52c1.sfr@canb.auug.org.au>
Date:	Mon, 19 Nov 2007 13:38:49 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	akpm@...ux-foundation.org, linuxppc-dev@...abs.org,
	anton@....ibm.com, paulus@...ba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure -
 mm/stab.c

Hi Kamalesh,

On Wed, 14 Nov 2007 16:24:10 +0530 Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com> wrote:
>
> +#ifdef CONFIG_PPC_ISERIES
> +#include <asm/iseries/hv_call.h>
> +#endif /* CONFIG_PPC_ISERIES */

You should not need the #ifdef and we prefer not to ifdef include unless
necessary.  Please resubmit.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped