linux-kernel - Re: [rfc 03/45] Generic CPU operations: Core piece

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711191927510.21689@schroedinger.engr.sgi.com>
Date:	Mon, 19 Nov 2007 19:30:55 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
cc:	ak@...e.de, akpm@...ux-foundation.org, travis@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [rfc 03/45] Generic CPU operations: Core piece

On Mon, 19 Nov 2007, Mathieu Desnoyers wrote:

> 
> Very interesting patch! I did not expect we could mix local atomic ops
> with per CPU offsets in an atomic manner.. brilliant :)
> 
> Some nitpicking follows...

Well this is a draft so I was not that thorough. The beast is getting too 
big. It would be good if I could get the first patches merged that just 
deal with the two allocators and then gradually work the rest.

> I think you could use extra () around old, new etc.. ?

Right.

> Same here.
> 
> > +	(x);					\
> 
> () seems unneeded here, since x is local.

But (x) is returned to the "caller" of the macro so it should be specially 
marged.

> > + * In that case we can simply disable preemption which
> > + * may be free if the kernel is compiled without preemption.
> > + */
> > +
> > +#define _CPU_READ(addr)				\
> > +({						\
> > +	(__CPU_READ(addr));			\
> > +})
> 
> ({ }) seems to be unneeded here.

Hmmm.... I wanted a consistent style.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/