linux-kernel - Re: 2.6.24-rc2 STD with s2disk fails to activate suspended system after loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071120055519.GD20436@elte.hu>
Date:	Tue, 20 Nov 2007 06:55:19 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Chris Friedhoff <chris@...edhoff.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.24-rc2 STD with s2disk fails to activate suspended system
	after loading - now 2.6.24-rc3


* Rafael J. Wysocki <rjw@...k.pl> wrote:

> > increasing CONFIG_BLK_DEV_RAM_SIZE from 7777 to 131072 hasn't 
> > changed the non-functioning of 2.6.24-rc3
> > 
> > s2disk works with 2.6.23.8 ; I tested 4 cycles in a row, 2 from 
> > console and 2 from within X
> 
> I've attached a patch to the bugzilla entry, please test it.
[...]
> --- linux-2.6.orig/init/do_mounts_initrd.c
> +++ linux-2.6/init/do_mounts_initrd.c
> @@ -55,6 +55,8 @@ static void __init handle_initrd(void)
>  	sys_mount(".", "/", NULL, MS_MOVE, NULL);
>  	sys_chroot(".");
>  
> +	current->flags |= PF_NOFREEZE;
> +
>  	pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD);
>  	if (pid > 0)
>  		while (pid != sys_wait4(-1, NULL, 0, NULL)) {

this is not the first time (and not the last time) that a missing 
PF_NOFREEZE is causing hard to debug suspend problems. I think we should 
be more robust about this and at minimum include some debug mechanism 
that determines when a PF_NOFREEZE annotation is missing. (or at least 
detect the condition somehow and report it) This bug took 10 days to 
track down.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/