linux-kernel - Re: [PATCH 01/59] arch/ia64: Add missing "space"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071120074132.GA3402@verge.net.au>
Date:	Tue, 20 Nov 2007 16:41:33 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, Jes Sorensen <jes@....com>,
	Tony Luck <tony.luck@...el.com>, linux-altix@....com,
	linux-ia64@...r.kernel.org
Subject: Re: [PATCH 01/59] arch/ia64: Add missing "space"

On Mon, Nov 19, 2007 at 11:09:25PM -0800, Joe Perches wrote:
> On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote:
> > Is it really neccessary for this fragment to create a line that
> > is greater than 80 characters long? Persumably the entire reason
> > that the printk line was split in the first place was to avoid
> > a long line.
> 
> No.  Many other lines in that source file are > 80 char.

That may be so, but surely adding another one makes
things slightly worse.

> My initial preference was to reformat the indented lines to the
> printk open parenthesis, but the minimal change seemed better.
> 
> cheers, Joe

-- 
Horms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/