linux-kernel - Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Nov 2007 08:55:15 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Mike Travis <travis@....com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Christoph Lameter <clameter@....com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array
 fix

On Wed, 14 Nov 2007, Mike Travis wrote:

> Hi Andrew,
> 
> It appears that this patch is missing from the latest 2.6.24 git kernel?
> 
> (Suresh noticed that it is still a problem.)
> 
> Thanks,
> Mike
> 
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
> 
> Signed-off-by: Mike Travis <travis@....com>
> ---
>  arch/x86_64/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux.orig/arch/x86_64/kernel/smpboot.c	2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c	2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
>  	struct cpuinfo_x86 *c = &cpu_data(id);
>  
>  	*c = boot_cpu_data;
> -	c->cpu_index = id;
>  	identify_cpu(c);
> +	c->cpu_index = id;
>  	print_cpu_info(c);
>  }

The correct fix is already in mainline:

commit 699d934d5f958d7944d195c03c334f28cc0b3669

	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/