linux-kernel - Re: [PATCH] checkpatch: Print filenames of patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071120091047.GA12066@shadowen.org>
Date:	Tue, 20 Nov 2007 09:11:00 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Print filenames of patches

On Sun, Nov 18, 2007 at 11:03:47AM +0100, Geert Uytterhoeven wrote:
> checkpatch: Print filenames of patches instead of the very uninformative
> `Your patch'.

Well this isn't quite enough as we often use this thing checking its
stdin.  Which leads to an even less useful '- has no obvious ...'.  I
guess a hybrid would be an improvement.

> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> This patch is not `checkpatch' clean :-)
> Although I shortened 2 lines, they're still longer than 80 characters...

Heh, yeah its a pig getting those RE's into 80 chars.

>  scripts/checkpatch.pl |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1408,10 +1408,10 @@ sub process {
>  		}
>  	}
>  	if ($clean == 1 && $quiet == 0) {
> -		print "Your patch has no obvious style problems and is ready for submission.\n"
> +		print "$filename has no obvious style problems and is ready for submission.\n"
>  	}
>  	if ($clean == 0 && $quiet == 0) {
> -		print "Your patch has style problems, please review.  If any of these errors\n";
> +		print "$filename has style problems, please review.  If any of these errors\n";
>  		print "are false positives report them to the maintainer, see\n";
>  		print "CHECKPATCH in MAINTAINERS.\n";
>  	}

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/