linux-kernel - Re: [PATCH 1/3] PNP cleanups - Make use of pnp_{port,mem,irq,dma}_{start,end,flags} macros wherever possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4742B403.6060802@keyaccess.nl>
Date:	Tue, 20 Nov 2007 11:16:35 +0100
From:	Rene Herman <rene.herman@...access.nl>
To:	trenn@...e.de
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	"Li, Shaohua" <shaohua.li@...el.com>,
	"yakui.zhao" <yakui.zhao@...el.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/3] PNP cleanups - Make use of	pnp_{port,mem,irq,dma}_{start,end,flags}
 macros wherever possible

On 20-11-07 10:51, Thomas Renninger wrote:

> Make use of pnp_{port,mem,irq,dma}_{start,end,flags} macros wherever possible
> 
> The macros to access the resource table in pnp sublayer was not used
> consequently.
> This patch makes use of these macros instead of accessing the resource
> arrays directly.
> 
> For dma and irq also pnp_{dma,irq}_{start,end} macros have been introduced
> to unify the access to the different resource types.
> 
> The pnp_{irq,dma} macros has now the same functionality than the:
> pnp_{irq,dma}_start macros. This will be cleaned up by the next patch.
> 
> Signed-off-by: Thomas Renninger <trenn@...e.de>

Earlier comments (in private mail):

>> -                dev->res.port_resource[nport].start =
>> +                pnp_port_start(dev, nport) =
>>                      simple_strtoul(buf, &buf, 0);
>> If I'm not mistaken, there's a standing fatwa on macros as lvalues.
>> Andrew?
> 
> Andrew Morton wrote: 
> 
> Well, it's a pretty nasty thing to do, IMO.  But given that we've already
> gone and done it I suppose the change is OK from a consistency POV.

Otherwise acked as identity transformation.

Acked-by: Rene Herman <rene.herman@...il.com>

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/