[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1195592198.7234.45.camel@heimdal.trondhjem.org>
Date: Tue, 20 Nov 2007 15:56:38 -0500
From: Trond Myklebust <trond.myklebust@....uio.no>
To: Christoph Lameter <clameter@....com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>, ak@...e.de,
akpm@...ux-foundation.org, travis@....com,
linux-kernel@...r.kernel.org
Subject: Re: [rfc 19/45] cpu alloc: NFS statistics
On Tue, 2007-11-20 at 12:49 -0800, Christoph Lameter wrote:
> On Tue, 20 Nov 2007, Mathieu Desnoyers wrote:
>
> > > Index: linux-2.6/fs/nfs/iostat.h
> > > ===================================================================
> > > --- linux-2.6.orig/fs/nfs/iostat.h 2007-11-15 21:17:24.391404458 -0800
> > > +++ linux-2.6/fs/nfs/iostat.h 2007-11-15 21:25:33.167654066 -0800
> > > @@ -123,7 +123,7 @@ static inline void nfs_inc_server_stats(
> > > int cpu;
> > >
> > > cpu = get_cpu();
> > > - iostats = per_cpu_ptr(server->io_stats, cpu);
> > > + iostats = CPU_PTR(server->io_stats, cpu);
> > > iostats->events[stat] ++;
> >
> > Is there a way to change this into a CPU_ADD ?
>
> Yes I must have missed that.
>
> Could be
>
> CPU_INC(server->io_stats->events[stat]);
>
> >
> > > put_cpu_no_resched();
> >
> > Why put_cpu_no_resched here ?
>
> We do not want to reschedule here? We may have already disabled interrupts
> or some such thing.
Some of these statistics are updated from inside a spinlocked
environment, hence the put_no_resched().
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists