linux-kernel - Re: [PATCH 13/18] x86 vDSO: ia32 sysenter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071121003413.D25F726F8BE@magilla.localdomain>
Date:	Tue, 20 Nov 2007 16:34:13 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Zachary Amsden <zach@...are.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return

> > @@ -104,7 +103,7 @@ ENTRY(ia32_sysenter_target)
> >  	pushfq
> >  	CFI_ADJUST_CFA_OFFSET 8
> >  	/*CFI_REL_OFFSET rflags,0*/
> > -	movl	$VSYSCALL32_SYSEXIT, %r10d
> > +	movl	8*3-THREAD_SIZE+threadinfo_sysenter_return(%rsp), %r10d
> 
> 8*3-THREAD_SIZE is not very intuitive.  Can you add a comment on the
> math?

When you are reading the whole stretch of code right there, and not just
the patch, it's fairly obvious that it matches the three pushes right there.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/