linux-kernel - Re: [PATCH 5/5] x86: TLS cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.9999.0711211253470.25057@localhost.localdomain>
Date:	Wed, 21 Nov 2007 12:58:38 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Roland McGrath <roland@...hat.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] x86: TLS cleanup

On Wed, 21 Nov 2007, Roland McGrath wrote:

> 
> This consolidates the four different places that implemented the same
> encoding magic for the GDT-slot 32-bit TLS support.  The old tls32.c is
> renamed and only slightly modified to be the shared implementation guts.

Cool patchset. 

One minor nit: Please do not put stuff into proto.h anymore. I'm
desperately trying to get rid of it.

> diff --git a/include/asm-x86/proto.h b/include/asm-x86/proto.h
> index dabba55..a7aa17d 100644
> --- a/include/asm-x86/proto.h
> +++ b/include/asm-x86/proto.h
> @@ -24,6 +24,11 @@ extern void ia32_syscall(void);
>  extern void ia32_cstar_target(void); 
>  extern void ia32_sysenter_target(void); 
>  
> +extern int do_get_thread_area(struct task_struct *p, int idx,
> +			      struct user_desc __user *info);
> +extern int do_set_thread_area(struct task_struct *p, int idx,
> +			      struct user_desc __user *info, int can_allocate);
> +
>  extern void config_acpi_tables(void);
>  extern void ia32_syscall(void);

I pull it into the x86 git tree and look for a better place for
do_[sg]et_thread_area()

Thanks,

	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/