linux-kernel - Re: [linux-usb-devel] USB deadlock after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200711212141.13102.laurent.pinchart@skynet.be>
Date:	Wed, 21 Nov 2007 21:41:12 +0100
From:	Laurent Pinchart <laurent.pinchart@...net.be>
To:	linux-usb-devel@...ts.sourceforge.net
Cc:	"Markus Rechberger" <mrechberger@...il.com>,
	"Oliver Neukum" <oliver@...kum.org>,
	Laurent Pinchart <laurentp@...-semaphore.com>,
	Mark Lord <lkml@....ca>, linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] USB deadlock after resume

On Wednesday 21 November 2007, Markus Rechberger wrote:
> On 11/21/07, Oliver Neukum <oliver@...kum.org> wrote:
> > Am Mittwoch 21 November 2007 schrieb Markus Rechberger:
> > > > Which URB is usb_kill_urb() called for?
> > >
> > > it's the usb_control_message which calls usb_kill_urb if I haven't got
> > > it wrong. (if you're looking for some other information please let me
> > > know)
> > > Although, I got a bit further with it. The error seems to happen
> > > earlier already.
> > > If I load the driver, and do not access the device after suspending
> > > all usb_control commands fail with -71 eproto.
> >
> > A timeout. You should add the RESET_RESUME quirk for your device.
> > usb_reset_device() from resume() is not a good idea.
>
> ok this is good to know, although I have to stick with kernel 2.6.21.3
> here. It's Laurent's driver best would be to check for the specific
> kernelversion and do whatever is appropriate.

I like the RESET_RESUME quirk best. Adding a new quirk to the uvcvideo driver 
doesn't really make sense when the USB subsystem is already able to handle 
this situation.

Best regards,

Laurent Pinchart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/