linux-kernel - Re: [PATCH] Add the word 'Warning' in check_nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.9999.0711212137380.25057@localhost.localdomain>
Date:	Wed, 21 Nov 2007 21:41:25 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Don Zickus <dzickus@...hat.com>
cc:	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, mingo@...hat.com
Subject: Re: [PATCH] Add the word 'Warning' in check_nmi_watchdog() output

On Wed, 21 Nov 2007, Don Zickus wrote:

> On Wed, Nov 21, 2007 at 10:34:59AM -0800, Arjan van de Ven wrote:
> > On Wed, 21 Nov 2007 12:14:20 -0500
> > Don Zickus <dzickus@...hat.com> wrote:
> > 
> > > Our automated test suite looks for keywords like error, fail, warning
> > > in the boot log.  In the case when the nmi watchdog is determined to
> > > be stuck in check_nmi_watchdog(), none of those keywords are
> > > displayed.
> > 
> > 
> > please make it at least consistent with the other kernel level bad
> > things, and use "WARNING:"....
> 
> Good point.  I'll repost.

Before you repost, please add an appropriate KERN_WARN prefix to the
printk and run your patch through scripts/checkpatch.pl.

	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/